Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper LICENSE files #33

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Add proper LICENSE files #33

merged 1 commit into from
Jan 16, 2020
+30 −0

Conversation

chrisr-diffblue
Copy link
Contributor

@chrisr-diffblue chrisr-diffblue commented Dec 10, 2019 •
edited by peterschrammel
Loading

@kroening @peterschrammel - I need your input on license files for hw-cbmc:

  • For the top-level license file for HW-CBMC, what are the copyright years, names and organisations? Are they the same as CBMC (which is where I copied this license from) or are they different?

peterschrammel
peterschrammel requested changes Dec 12, 2019
View reviewed changes
@chrisr-diffblue
Copy link
Contributor Author

LICENSE file has been changed to the 3-clause version - note that at the present time this PR is now showing the change for some reason, but if you view the license-files branch you'll see the updated version there.

peterschrammel
peterschrammel reviewed Jan 8, 2020
View reviewed changes
Copy link
Member

@peterschrammel peterschrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still the 4-clause version. Please change to 3-clause. @kroening, please confirm that Ed Clarke can be removed.

@chrisr-diffblue
Copy link
Contributor Author

@peterschrammel - I'm not sure whats going on at the moment - the source branch for this PR has the 3-clause license (if you browse to the branch, that can be seen) but for some reason this PR is not seeing the appropriate diff.... I'll see if I can figure out why.

@chrisr-diffblue
Copy link
Contributor Author

@peterschrammel - OK, I changed the commit message and force pushed and that seems to have been enough this time to get the PR to update.

@kroening kroening removed their assignment Jan 15, 2020
peterschrammel
peterschrammel reviewed Jan 15, 2020
View reviewed changes
LICENSE Outdated
@@ -0,0 +1,30 @@
(C) 2001-2019, Daniel Kroening, Edmund Clarke,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(C) 2001-2019, Daniel Kroening, Edmund Clarke,
(C) 2001-2020, Daniel Kroening, Edmund Clarke,

@chrisr-diffblue
Copy link
Contributor Author

Copyright dates have been updated.

@chrisr-diffblue chrisr-diffblue merged commit a82de96 into master Jan 16, 2020
@kroening kroening deleted the license-files branch September 9, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterschrammel peterschrammel peterschrammel approved these changes

@kroening kroening kroening approved these changes

Assignees

@peterschrammel peterschrammel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisr-diffblue @kroening @peterschrammel